-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add npx
conversions
#53
Conversation
@nebrelbug should I add tests before merging ? |
@Jay-Karia Yeah tests would be great, thanks |
…pm-to-yarn into feat/npx-conversions
@slorber, I'd love to hear your thoughts about this proposal since Docusaurus is one of the main users of npm-to-yarn. |
Yes that looks like a useful feature to add that we could use on the Docusaurus website |
@Jay-Karia I think for ease of use, it should detect whether or not it is an executor command (test for |
Instead of giving additional parameter for npx conversions, now it automatically detects for this type of conversion
Now `yarn dlx`, `pnpm dlx` and `bun x` commands can be converted internally. Previously it was only `npx`
@nebrelbug Should we consider updating the version to: |
added to new tests and updated the existing tests for `npx` conversions.
Removed extra argument in API usage as it now auto detects npx conversions
@nebrelbug Removed extra argument |
This comment was marked as outdated.
This comment was marked as outdated.
|
This comment was marked as resolved.
This comment was marked as resolved.
@Jay-Karia thanks for the great work! I think we should probably update to a major version. Do you think this is ready to merge? |
Yes |
I just merged this (with the CLI, not through the web client) and released in https://github.com/nebrelbug/npm-to-yarn/releases/tag/v3.0.0! Thanks for your help! |
Note: that's a bit unfortunate but it looks like For this reason the limits the adoption of this feature. I don't think it's a good idea to use it on the Docusaurus website because many users use Yarn 1 (including ourselves) |
is |
I don't see it listed here: https://classic.yarnpkg.com/en/docs/cli/ However |
This PR adds a new type of conversions (for
npx
).The command
npx create-next-app
is converted into:yarn dlx create-next-app
(yarn)pnpm dlx create-next-app
(pnpm)bun x create-next-app
(bun)Automatically detects executor commands and converts it
Here's a code example.
Closes #48