@Space property configurable supported #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CorvusYe
reviewed
Sep 3, 2024
| @@ -74,7 +74,7 @@ private void setBeans(ConfigurableListableBeanFactory beanFactory) { | |||
| } | |||
|
|
|||
| public MapperContext mapperContext(NebulaPool nebulaPool) { | |||
| DaoResourceLoader daoBasicResourceLoader = new DaoResourceLoader(parseCfgProps); | |||
| DaoResourceLoader daoBasicResourceLoader = new DaoResourceLoader(parseCfgProps,this.context); | |||
There was a problem hiding this comment.
这边代码风格检查应该是通不过，参数间需要空格，单行代码不超过 100 个字符长度好像
src/main/java/org/nebula/contrib/ngbatis/io/MapperResourceLoader.java
Outdated
Show resolved
Hide resolved
OKOK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@space注解值可通过spring配置文件配置
方法：在获取@space注解name时，通过Spring的 Environment 对象的 resolveRequiredPlaceholders 方法解析配置，同时也兼容固定name的情况。
使用示例： @space(name = "${nebula.secondSpace}") ， spring配置文件中若无 nebula.secondSpace 自定义配置则抛出ResourceLoadException
核心改动：
