fix: Ignore stderr when getting version

Simplify `conda--get-version` to a) stop using a shell, and b) discard stderr, so we don't try to parse any diagnostic messages as a version.
necaris · Oct 5, 2024 · 4788cf7 · 4788cf7
1 parent ce748a5
commit 4788cf7
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/conda.el b/conda.el
@@ -149,7 +149,9 @@ Set for the lifetime of the process.")
 Cached for the lifetime of the process."
   (if (not (eq conda--installed-version nil))
       conda--installed-version
-    (let ((version-output (shell-command-to-string (format "\"%s\" -V" (conda--get-executable-path)))))
+    (let ((version-output (with-temp-buffer
+                            (call-process (conda--get-executable-path) nil '(t nil) nil "-V")
+                            (buffer-string))))
       (condition-case err
           (s-with version-output
             (s-trim)