Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(🐞) fix: Remove missing type parameter #1570

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Conversation

KotlinIsland
Copy link
Contributor

This missing type parameter is causing errors in some usages

@nedbat
Copy link
Owner

nedbat commented Mar 3, 2023

Can you explain what usages are causing errors?

@KotlinIsland
Copy link
Contributor Author

KotlinIsland commented Mar 3, 2023

Coverage doesn't actually support a os.PathLike[bytes] for config_file:

a: os.PathLike[bytes] = get_bytes_path()
Coverage(config_file=a)
...
  File "/coveragepy/coverage/config.py", line 558, in config_files_to_try
    assert isinstance(config_file, str)
AssertionError

Also in basedmypy you will get an error if you call a partially typed function, so any usage of Coverage report:

Coverage(data_file=path)  # error: Call to incomplete function "Coverage" in typed context  [no-untyped-call]

@nedbat nedbat merged commit 021a99f into nedbat:master Mar 15, 2023
@KotlinIsland KotlinIsland deleted the fix/types branch March 15, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants