Fixed build, Network selection and smart contract function execution bugs. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated dependency gulp to use the default npm gulp 4.0.0 package because the "github:gulpjs/gulp#4.0" path seems to be dead. createErrorMiddleware.js - Edited createErrorMiddleware function to return done() even on error so web3 contract function calls can complete properly. network.js - Restored the MAINNET constant in the INFURA_PROVIDER_TYPES array to fix mainnet selection. - Modified NetworkController::_configureProvider method to skip Infuria provider evaluation. Nuko needs to be setup with Infuria and we can go back to using it.
- Spelled infura wrong in NetworkController::_configureProvider method comment.
|
Thank you for maintenance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createErrorMiddleware.js
network.js