fix: avoid race condition by not running exec/start twice

ContainerExecAttach implicitly runs ContainerExecStart while attaching to stdout/stderr. Ref: https://github.com/moby/moby/blob/e02bc91dcbf6ab70ab39352f3577a4394b0f863a/client/container_exec.go#L40 Calling both can lead to a race condition as observed in #627 Fixes: #627 Co-authored-by: Markus Wolf <[email protected]>
nektos · May 23, 2021 · 56f7fab · 56f7fab
1 parent 764263c
commit 56f7fab
Showing 1 changed file with 0 additions and 7 deletions.
diff --git a/pkg/container/docker_run.go b/pkg/container/docker_run.go
@@ -456,13 +456,6 @@ func (cr *containerReference) exec(cmd []string, env map[string]string) common.E
 			errWriter = os.Stderr
 		}
 
-		err = cr.cli.ContainerExecStart(ctx, idResp.ID, types.ExecStartCheck{
-			Tty: isTerminal,
-		})
-		if err != nil {
-			return errors.WithStack(err)
-		}
-
 		if !isTerminal || os.Getenv("NORAW") != "" {
 			_, err = stdcopy.StdCopy(outWriter, errWriter, resp.Reader)
 		} else {