Fix review comment

nektos · Mar 1, 2023 · 9de011a · 9de011a
1 parent 7baa65b
commit 9de011a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/exprparser/interpreter.go b/pkg/exprparser/interpreter.go
@@ -368,7 +368,7 @@ func (impl *interperterImpl) compareValues(leftValue reflect.Value, rightValue r
 
 	case reflect.Invalid:
 		if rightValue.Kind() == reflect.Invalid {
-			return false, nil
+			return true, nil
 		}
 
 		// not possible situation - params are converted to the same type in code above

diff --git a/pkg/exprparser/interpreter_test.go b/pkg/exprparser/interpreter_test.go
@@ -72,7 +72,7 @@ func TestOperators(t *testing.T) {
 		{"github.event.commits[0].author.username != github.event.commits[1].author.username", true, "property-comparison1", ""},
 		{"github.event.commits[0].author.username1 != github.event.commits[1].author.username", true, "property-comparison2", ""},
 		{"github.event.commits[0].author.username != github.event.commits[1].author.username1", true, "property-comparison3", ""},
-		{"github.event.commits[0].author.username1 != github.event.commits[1].author.username2", false, "property-comparison4", ""},
+		{"github.event.commits[0].author.username1 != github.event.commits[1].author.username2", true, "property-comparison4", ""},
 		{"secrets != env", nil, "property-comparison5", "Compare not implemented for types: left: map, right: map"},
 	}