fix: docker cp of dangling symlink (#943) (#948)

Co-authored-by: Josh Soref <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

pkg/container/docker_run.go

@@ -627,6 +627,11 @@ func (cr *containerReference) copyDir(dstPath string, srcPath string, useGitIgno
 				return err
 			}
 
+			// symlinks don't need to be copied
+			if fi.Mode()&os.ModeSymlink == os.ModeSymlink {
+				return nil
+			}
+
 			// open files for taring
 			f, err := os.Open(file)
 			if err != nil {
@@ -635,10 +640,6 @@ func (cr *containerReference) copyDir(dstPath string, srcPath string, useGitIgno
 
 			// copy file data into tar writer
 			if _, err := io.Copy(tw, f); err != nil {
-				if fi.Mode()&os.ModeSymlink == os.ModeSymlink {
-					// symlinks don't need to be copied, ignore this error
-					err = nil
-				}
 				return err
 			}