Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: panic: reflect: slice index out of range #1066

Merged
merged 5 commits into from
Mar 22, 2022
Merged

Fix: panic: reflect: slice index out of range #1066

merged 5 commits into from
Mar 22, 2022

Conversation

ChristopherHX
Copy link
Contributor

panics are very bad

@ChristopherHX ChristopherHX requested a review from a team as a code owner March 21, 2022 20:22
@ChristopherHX ChristopherHX linked an issue Mar 21, 2022 that may be closed by this pull request
panic: reflect: slice index out of range #1064
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2022 •
edited
Loading

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 1.37s
✅ EDITORCONFIG editorconfig-checker 2 0 1.09s
✅ GIT git_diff yes no 0.02s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2022

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022 •
edited
Loading

Codecov Report

Merging #1066 (73f2251) into master (4f8da0a) will increase coverage by 1.43%.
The diff coverage is 80.12%.

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
+ Coverage   57.50%   58.94%   +1.43%     
==========================================
  Files          32       33       +1     
  Lines        4594     4650      +56     
==========================================
+ Hits         2642     2741      +99     
+ Misses       1729     1681      -48     
- Partials      223      228       +5
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <ø> (ø)
pkg/model/planner.go 50.73% <ø> (+0.32%) ⬆️
pkg/runner/logger.go 66.00% <67.56%> (+0.56%) ⬆️
pkg/exprparser/interpreter.go 74.57% <75.00%> (+1.17%) ⬆️
pkg/runner/runner.go 74.52% <75.00%> (-1.95%) ⬇️
pkg/runner/expression.go 89.36% <77.61%> (-1.46%) ⬇️
pkg/runner/job_executor.go 82.05% <82.05%> (ø)
pkg/runner/action.go 84.21% <84.21%> (ø)
pkg/runner/step_context.go 85.81% <84.61%> (+4.17%) ⬆️
pkg/runner/run_context.go 79.60% <86.20%> (-0.05%) ⬇️
... and 11 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Mar 21, 2022
catthehacker
catthehacker previously approved these changes Mar 21, 2022
View reviewed changes
KnisterPeter
KnisterPeter requested changes Mar 22, 2022
View reviewed changes
pkg/exprparser/interpreter.go Outdated Show resolved Hide resolved
@mergify mergify bot merged commit a970145 into master Mar 22, 2022
@mergify mergify bot deleted the christopherhx/fix/arrayderef branch March 22, 2022 18:05
ChristopherHX added a commit to ChristopherHX/act that referenced this pull request Apr 24, 2022
@ChristopherHX @mergify
Fix: panic: reflect: slice index out of range (nektos#1066)
3c8be49 
* Fix: panic: reflect: slice index out of range

* Update interpreter.go

* [no ci] Return null for negative indexes

* Add tests for index access

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZauberNerd ZauberNerd ZauberNerd approved these changes

@catthehacker catthehacker catthehacker approved these changes

@KnisterPeter KnisterPeter KnisterPeter approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: reflect: slice index out of range
4 participants
@ChristopherHX @ZauberNerd @KnisterPeter @catthehacker