Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't overwrite with empty cmd/entrypoint #1076

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

catthehacker
Copy link
Member

fixes #917
Signed-off-by: Ryan [email protected]

@catthehacker catthehacker requested a review from a team as a code owner March 25, 2022 13:39
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 1.01s
✅ EDITORCONFIG editorconfig-checker 2 0 0.7s
✅ GIT git_diff yes no 0.01s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@mergify

This comment was marked as outdated.

@mergify mergify bot added the needs-work Extra attention is needed label Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #1076 (8a09edd) into master (4f8da0a) will increase coverage by 2.48%.
The diff coverage is 83.77%.

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
+ Coverage   57.50%   59.99%   +2.48%     
==========================================
  Files          32       38       +6     
  Lines        4594     4839     +245     
==========================================
+ Hits         2642     2903     +261     
+ Misses       1729     1704      -25     
- Partials      223      232       +9     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <ø> (ø)
pkg/model/planner.go 50.73% <ø> (+0.32%) ⬆️
pkg/container/docker_run.go 4.88% <5.00%> (-0.66%) ⬇️
pkg/runner/logger.go 66.00% <67.56%> (+0.56%) ⬆️
pkg/runner/runner.go 72.80% <71.69%> (-3.67%) ⬇️
pkg/exprparser/interpreter.go 74.57% <75.00%> (+1.17%) ⬆️
pkg/runner/expression.go 91.02% <78.26%> (+0.20%) ⬆️
pkg/runner/step.go 80.76% <80.76%> (ø)
pkg/runner/run_context.go 78.84% <82.50%> (-0.81%) ⬇️
pkg/runner/action.go 83.46% <83.46%> (ø)
... and 16 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Mar 25, 2022
KnisterPeter
KnisterPeter previously approved these changes Mar 25, 2022
ChristopherHX
ChristopherHX previously approved these changes Mar 25, 2022
pkg/runner/step_docker.go Outdated Show resolved Hide resolved
ZauberNerd
ZauberNerd previously approved these changes Mar 29, 2022
KnisterPeter
KnisterPeter previously approved these changes Mar 29, 2022
ZauberNerd
ZauberNerd previously approved these changes Mar 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2022

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Mar 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2022

@catthehacker this pull request has failed checks 🛠

Co-authored-by: ChristopherHX <[email protected]>

Signed-off-by: Ryan <[email protected]>
@mergify mergify bot removed the needs-work Extra attention is needed label Mar 29, 2022
@mergify mergify bot requested a review from a team March 29, 2022 17:51
@mergify mergify bot merged commit 24422bf into master Mar 29, 2022
@mergify mergify bot deleted the fix/uses-docker-entrypoint branch March 29, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: failed to run docker containers as steps
5 participants