Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editorconfig): correct braces #1094

Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix(editorconfig): correct braces #1094

merged 1 commit into from
Mar 30, 2022

Conversation

catthehacker
Copy link
Member

Apparently it's wrong in current form, and it doesn't work in JetBrains IDEs but it seemed to work in VSCode, so fixing
Signed-off-by: Ryan [email protected]

@catthehacker catthehacker requested a review from a team as a code owner March 30, 2022 16:44
@catthehacker catthehacker changed the title fix(editorconfig): correct casing fix(editorconfig): correct braces Mar 30, 2022
@github-actions
Copy link
Contributor

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 0.96s
✅ EDITORCONFIG editorconfig-checker 1 0 0.55s
✅ GIT git_diff yes no 0.01s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #1094 (e28d021) into master (4f8da0a) will increase coverage by 2.48%.
The diff coverage is 83.77%.

@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
+ Coverage   57.50%   59.99%   +2.48%     
==========================================
  Files          32       38       +6     
  Lines        4594     4839     +245     
==========================================
+ Hits         2642     2903     +261     
+ Misses       1729     1704      -25     
- Partials      223      232       +9     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <ø> (ø)
pkg/model/planner.go 50.73% <ø> (+0.32%) ⬆️
pkg/container/docker_run.go 4.88% <5.00%> (-0.66%) ⬇️
pkg/runner/logger.go 66.00% <67.56%> (+0.56%) ⬆️
pkg/runner/runner.go 72.80% <71.69%> (-3.67%) ⬇️
pkg/exprparser/interpreter.go 74.57% <75.00%> (+1.17%) ⬆️
pkg/runner/expression.go 91.02% <78.26%> (+0.20%) ⬆️
pkg/runner/step.go 80.76% <80.76%> (ø)
pkg/runner/run_context.go 78.84% <82.50%> (-0.81%) ⬇️
pkg/runner/action.go 83.46% <83.46%> (ø)
... and 16 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 8d41f7a into master Mar 30, 2022
@mergify mergify bot deleted the fix/editorconfig branch March 30, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants