Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove runTestJobFile #1127

Merged
merged 3 commits into from
Apr 19, 2022
Merged

tests: remove runTestJobFile #1127

merged 3 commits into from
Apr 19, 2022

Conversation

catthehacker
Copy link
Member

This prevented CLion GoLand 🤦‍♂️ from recognising subtests and treated it all as single big test, VSCode seems to be still broken in that regard
before:
image

after:
image

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 0.9s
✅ EDITORCONFIG editorconfig-checker 2 0 0.45s
✅ GIT git_diff yes no 0.0s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1127 (93b2149) into master (4f8da0a) will increase coverage by 2.55%.
The diff coverage is 79.16%.

@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
+ Coverage   57.50%   60.06%   +2.55%     
==========================================
  Files          32       39       +7     
  Lines        4594     4938     +344     
==========================================
+ Hits         2642     2966     +324     
- Misses       1729     1730       +1     
- Partials      223      242      +19     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <ø> (ø)
pkg/model/planner.go 50.73% <ø> (+0.32%) ⬆️
pkg/model/workflow.go 50.91% <ø> (ø)
pkg/container/docker_run.go 5.11% <2.50%> (-0.43%) ⬇️
pkg/common/git.go 49.31% <28.57%> (-0.52%) ⬇️
pkg/container/file_collector.go 44.85% <44.85%> (ø)
pkg/runner/logger.go 66.00% <67.56%> (+0.56%) ⬆️
pkg/runner/runner.go 73.72% <73.68%> (-2.75%) ⬇️
pkg/exprparser/interpreter.go 74.57% <75.00%> (+1.17%) ⬆️
pkg/runner/expression.go 91.02% <78.26%> (+0.20%) ⬆️
... and 19 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

This prevented JetBrains GoLand from recognising subtests and treated
it all as single big test, VSCode seems to be still broken in that regard
@catthehacker catthehacker marked this pull request as ready for review April 15, 2022 01:19
@catthehacker catthehacker requested a review from a team as a code owner April 15, 2022 01:19
@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2022

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Apr 19, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2022

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot removed the needs-work Extra attention is needed label Apr 19, 2022
@mergify mergify bot merged commit 40492fe into master Apr 19, 2022
@mergify mergify bot deleted the tests/clion-fix branch April 19, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants