Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user level Docker socket to common paths #1416

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

bendrucker
Copy link
Contributor

In v4.13.0, Docker for Mac stopped providing /var/run/docker.sock, resulting in act failing on macOS. By default, it listens on ~/.docker/run/docker.sock instead.

This was a breaking change in a non-major release and a rollback is planned:

docker/for-mac#6529 (comment)

This PR adds the new socket path to the bugReport output. Hopefully seeing that the user-level socket is available will help users set DOCKER_HOST rather than filing a report.

In the long run, it sounds like Docker wants people to move away from hardcoding a Docker host, default or otherwise, in their clients. docker context list will return the user's configured endpoints.

See #1411

@bendrucker bendrucker requested a review from a team as a code owner October 29, 2022 00:22
@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Merging #1416 (ffe6c38) into master (4f8da0a) will increase coverage by 6.39%.
The diff coverage is 74.70%.

@@            Coverage Diff             @@
##           master    #1416      +/-   ##
==========================================
+ Coverage   57.50%   63.90%   +6.39%     
==========================================
  Files          32       41       +9     
  Lines        4594     6452    +1858     
==========================================
+ Hits         2642     4123    +1481     
- Misses       1729     2034     +305     
- Partials      223      295      +72     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 12.82% <11.63%> (+7.27%) ⬆️
pkg/model/workflow.go 47.14% <22.22%> (-3.77%) ⬇️
pkg/model/planner.go 48.82% <25.00%> (-1.60%) ⬇️
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
pkg/container/file_collector.go 45.87% <45.87%> (ø)
pkg/common/git/git.go 50.00% <47.91%> (ø)
pkg/container/docker_auth.go 47.61% <50.00%> (+2.61%) ⬆️
pkg/exprparser/interpreter.go 73.37% <53.48%> (-0.02%) ⬇️
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit a73d506 into nektos:master Oct 29, 2022
@bendrucker bendrucker deleted the patch-1 branch October 31, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants