Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interpolate the step names #1422

Merged
merged 6 commits into from
Nov 16, 2022
Merged

feat: interpolate the step names #1422

merged 6 commits into from
Nov 16, 2022

Conversation

KnisterPeter
Copy link
Member

Step names could contain expressions refering to event data.

Fixes #1353

Step names could contain expressions refering to event data.

Fixes #1353
@KnisterPeter KnisterPeter self-assigned this Nov 1, 2022
@KnisterPeter KnisterPeter requested a review from a team as a code owner November 1, 2022 08:40
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2022

@KnisterPeter this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Nov 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 7 0 0.02s
✅ REPOSITORY gitleaks yes no 2.42s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.9s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Nov 2, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

@KnisterPeter this pull request has failed checks 🛠

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

@KnisterPeter this pull request has failed checks 🛠

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

@KnisterPeter this pull request has failed checks 🛠

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

@KnisterPeter this pull request has failed checks 🛠

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

@KnisterPeter this pull request has failed checks 🛠

The RunContext does contain a cached ExpressionEvaluator.
This should be the case the composite RunContext as well.
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #1422 (0ebda28) into master (4f8da0a) will increase coverage by 2.80%.
The diff coverage is 66.46%.

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
+ Coverage   57.50%   60.31%   +2.80%     
==========================================
  Files          32       44      +12     
  Lines        4594     6985    +2391     
==========================================
+ Hits         2642     4213    +1571     
- Misses       1729     2463     +734     
- Partials      223      309      +86     
Impacted Files Coverage Δ
pkg/common/file.go 0.00% <0.00%> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 12.82% <11.53%> (+7.27%) ⬆️
pkg/model/workflow.go 45.65% <23.80%> (-5.26%) ⬇️
...ontainer/linux_container_environment_extensions.go 24.32% <24.32%> (ø)
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
pkg/container/file_collector.go 37.30% <37.30%> (ø)
... and 36 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Nov 2, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2022

@KnisterPeter this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Nov 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2022

@KnisterPeter this pull request has failed checks 🛠

@mergify mergify bot removed the needs-work Extra attention is needed label Nov 16, 2022
@mergify mergify bot merged commit 809da71 into master Nov 16, 2022
@mergify mergify bot deleted the interpolate-step-name branch November 16, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

act does not evaluate step names
2 participants