feat: allow to spawn and run a local reusable workflow #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnisterPeter
force-pushed
the
local-reusable-workflows
branch
from
84876e7
to
9f6a117
Compare
🦙 MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## master #1423 +/- ##
==========================================
+ Coverage 57.50% 61.41% +3.90%
==========================================
Files 32 46 +14
Lines 4594 7124 +2530
==========================================
+ Hits 2642 4375 +1733
- Misses 1729 2443 +714
- Partials 223 306 +83
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KnisterPeter
force-pushed
the
local-reusable-workflows
branch
from
9f6a117
to
e0852b3
Compare
This change contains the ability to parse/plan/run a local reusable workflow. There are still numerous things missing: - inputs - secrets - outputs
KnisterPeter
force-pushed
the
local-reusable-workflows
branch
from
4502a35
to
74da5b0
Compare
| @@ -315,6 +315,8 @@ func rewriteSubExpression(ctx context.Context, in string, forceFormat bool) (str | |||
| func getEvaluatorInputs(ctx context.Context, rc *RunContext, step step, ghc *model.GithubContext) map[string]interface{} { | |||
| inputs := map[string]interface{}{} | |||
|
|
|||
| setupWorkflowInputs(ctx, &inputs, rc) | |||
There was a problem hiding this comment.
Move this behind workflow_dispatch (line 349) ?, because workflow_call has precedence and unset inputs are filled up by workflow_dispatch inputs of the parent workflow.
The workflow_dispatch on field is probably wrong in this case..., the value is correct.
Is github.event_name / ghc.EventName correctly set the parent / grandparent event_name? It is never workflow_call.
There was a problem hiding this comment.
The inputs in the expression evaluator are a bit messy currently.
We should consider refactoring the setup of the evaluator to be more flexible and factor in the context availability.
Currently we only have to kind of fixed setups for the expression evaluator which is too tightly coupled.
| } | ||
|
|
||
| if value == nil && config != nil && config.Inputs != nil { | ||
| value = input.Default |
There was a problem hiding this comment.
Based on my research, the inputs ctx is available here as the workflow_dispatch inputs of the caller workflow.
ChristopherHX
approved these changes
Dec 7, 2022
cplee
approved these changes
Dec 15, 2022
aholmes
added a commit
to aholmes/act
that referenced
this pull request
Dec 15, 2022
* feat: allow to spawn and run a local reusable workflow This change contains the ability to parse/plan/run a local reusable workflow. There are still numerous things missing: - inputs - secrets - outputs * feat: add workflow_call inputs * test: improve inputs test * feat: add input defaults * feat: allow expressions in inputs * feat: use context specific expression evaluator * refactor: prepare for better re-usability * feat: add secrets for reusable workflows * test: use secrets during test run * feat: handle reusable workflow outputs Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Dec 19, 2022
* Support "result" on "needs" context. This change adds "result" to a job's "needs" context, as documented [here](https://docs.github.com/en/actions/learn-github-actions/contexts#needs-context). `act` currently tracks the success/failure/cancelled status of a job, but does not include this value the `needs` context. Fixes #1367 * Change `Needs` to use a new struct rather than the open type `interface{}`. Related #1497 Fixes #1367 * Add integration test to "needs" context change. Relates: #1497 * feat: allow to spawn and run a local reusable workflow (#1423) * feat: allow to spawn and run a local reusable workflow This change contains the ability to parse/plan/run a local reusable workflow. There are still numerous things missing: - inputs - secrets - outputs * feat: add workflow_call inputs * test: improve inputs test * feat: add input defaults * feat: allow expressions in inputs * feat: use context specific expression evaluator * refactor: prepare for better re-usability * feat: add secrets for reusable workflows * test: use secrets during test run * feat: handle reusable workflow outputs Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * refactor: fix savestate in pre steps (#1466) * refactor: fix savestate in pre steps * fix pre steps collision * fix tests * remove * enable tests * Update pkg/runner/action.go * Rename InterActionState to IntraActionState Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * fix: tail (not absolute) as entrypoint of job container (#1506) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fix conflict in merge. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change contains the ability to parse/plan/run a local reusable workflow.
There are still numerous things missing: