Pass LANG=C.UTF-8 to environment

[bric3]

In order to use act with workflows where any tools, like build tools, depends on the locale being UTF-8, one must pass via command line via the --env option.

However the Github Actions runner already passes LANG=C.UTF-8 by default, which makes the need to explicitly pass this variable via command line un-intuitive.

The PR here aims to make act pass that environment variable by default.

Fixes: #1308
Possibly #639

[bric3]

Out of scope question, what tool is used to label PR by size ?
It's just above 🤦‍♂️

[ChristopherHX]

The PR here aims to make act pass that environment variable by default.

I want to let you know:
This PR partially enforces LANG=C.UTF-8 and overrides an env defined in the workflow file. This now also defines LANG on windows, I'm not shure that github actions does this on windows.

on: push
env:
  LANG: de_DE.utf8
jobs:
  _:
    runs-on: ubuntu-latest
    steps:
    - run: env

[bric3]

Hi thanks for the feedback !

I want to let you know:
This PR partially enforces LANG=C.UTF-8 and overrides an env defined in the workflow file.

Ha ok, I thought the env map was later merged, and workflow envs were overidden.
Where do you think declaring the LANG should happen ?
I was also looking at this location

act/pkg/runner/run_context.go

Line 72 in 7754ba7

rc.Env["ACT"] = "true"

Could you point me to a better place for doing that.

This now also defines LANG on windows, I'm not shure that github actions does this on windows.

Ah good point ! I have no idea about that. I don't know how windows runners operate. What would be the best course of action if Windows runner don't.

---

I'm a novice in Go, so I'm happy for any advice in the current matter.

[ChristopherHX]

I think you can add a line here:

act/pkg/runner/run_context.go

Line 227 in 7754ba7

envList = append(envList, fmt.Sprintf("%s=%s", "RUNNER_TEMP", "/tmp"))

this code only runs if you use a linux docker container and not running directly on windows.
This should also allow overriding it via cli/workflow, but this has to be tested manually.

[bric3]

Thanks @ChristopherHX

[codecov]

Codecov Report

Merging #1476 (3b663ac) into master (4f8da0a) will increase coverage by 2.93%.
The diff coverage is 66.67%.

@@            Coverage Diff             @@
##           master    #1476      +/-   ##
==========================================
+ Coverage   57.50%   60.44%   +2.93%     
==========================================
  Files          32       44      +12     
  Lines        4594     7000    +2406     
==========================================
+ Hits         2642     4231    +1589     
- Misses       1729     2463     +734     
- Partials      223      306      +83     

Impacted Files	Coverage Δ
pkg/common/file.go	0.00% <0.00%> (ø)
pkg/container/docker_logger.go	52.08% <ø> (ø)
pkg/container/host_environment.go	0.00% <0.00%> (ø)
pkg/container/util.go	0.00% <0.00%> (ø)
pkg/model/action.go	0.00% <0.00%> (ø)
pkg/model/step_result.go	0.00% <ø> (ø)
pkg/container/docker_run.go	12.82% <11.53%> (+7.27%)	⬆️
pkg/model/workflow.go	45.65% <23.58%> (-5.26%)	⬇️
...ontainer/linux_container_environment_extensions.go	24.32% <24.32%> (ø)
pkg/container/docker_pull.go	33.33% <33.33%> (ø)
... and 37 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ChristopherHX]

Works now as expected from my side. Both overriding the default LANG from cli and workflow file works.