refactor: remove docker image list reference filter #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherHX
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1501 +/- ##
==========================================
+ Coverage 61.22% 61.44% +0.21%
==========================================
Files 46 46
Lines 7141 7148 +7
==========================================
+ Hits 4372 4392 +20
+ Misses 2462 2450 -12
+ Partials 307 306 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ChristopherHX
commented
Dec 11, 2022
|
|
||
| imageListOptions := types.ImageListOptions{ | ||
| Filters: filters, | ||
| inspectImage, _, err := cli.ImageInspectWithRaw(ctx, imageName) |
There was a problem hiding this comment.
One docker inpect call is enough, no container list needed with non portable filters
Docker beta only, they may contribute the filter to containerd
| return false, err | ||
| } | ||
|
|
||
| cli, err := GetDockerClient(ctx) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| defer cli.Close() |
There was a problem hiding this comment.
Did I forget this leak or is it new? Should be closed.
Seems like it got lost, my fork has a close instruction and, I have made the last change in this file.
It is better to keep two return values
|
We have a CI issue, not shure if it is permanent |
ChristopherHX
changed the title
cplee
approved these changes
Jan 10, 2023
|
@ChristopherHX this pull request has failed checks 🛠 |
mergify
bot
added
needs-work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should I preserve the public ImageExistsLocally signature and make a private helper function?, reverted the new return value.This uses docker inspect and remove docker list.
You cannot have multiple images of the same name+tag, regardless of platform metadata
Fixes #1390