feat: add support for building docker actions with private registries #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZauberNerd this pull request has failed checks 🛠 |
KnisterPeter
previously approved these changes
Jan 12, 2023
This commit adds a new `LoadDockerAuthConfigs` function, which loads all registry auths that are configured on the host and sends them with the build command to the docker daemon. This is needed in case act builds a docker action and the images referenced in that docker action are located on private registries or otherwise require authentication (e.g. to get a higher rate limit). The code is adapted from how the docker cli works: https://github.com/docker/cli/blob/257ff41304bf121bdf1acdf00a1c7a896ed038d1/cli/command/image/build.go#L323-L332 Co-authored-by: Markus Wolf <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1557 +/- ##
==========================================
+ Coverage 61.22% 61.26% +0.04%
==========================================
Files 46 46
Lines 7141 7167 +26
==========================================
+ Hits 4372 4391 +19
- Misses 2462 2467 +5
- Partials 307 309 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ZauberNerd
force-pushed
the
docker-build-authenticated
branch
from
b08a03e
to
0aff358
Compare
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
KnisterPeter
approved these changes
Jan 12, 2023
cplee
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
LoadDockerAuthConfigsfunction, which loads all registry auths that are configured on the host and sends them with the build command to the docker daemon.This is needed in case act builds a docker action and the images referenced in that docker action are located on private registries or otherwise require authentication (e.g. to get a higher rate limit).
The code is adapted from how the docker cli works: https://github.com/docker/cli/blob/257ff41304bf121bdf1acdf00a1c7a896ed038d1/cli/command/image/build.go#L323-L332