-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add check for newer versions #1562
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report
@@ Coverage Diff @@
## master #1562 +/- ##
==========================================
+ Coverage 61.22% 61.45% +0.22%
==========================================
Files 46 46
Lines 7141 7157 +16
==========================================
+ Hits 4372 4398 +26
+ Misses 2462 2452 -10
Partials 307 307
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I have two questions:
- The logger does output only text. If act is started with '--json' it should respect that. Otherwise the log would not be parsable
- Why is the go-git patch by ZauberNerd removed?
Good catch @KnisterPeter . I updated to honor the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We should check with @ZauberNerd. |
It was looking for tag |
Is it expected behavior to always show new version is available for source builds without an explicit version? |
@cplee this pull request has failed checks 🛠 |
@ChristopherHX - updated to keep the source version aligned with release version. This will avoid alerting on new versions if built from source...unless there is in fact a new version available. Fixed #1069 and #1555 too... |
Oh, I rebased my PR go-git/go-git#485 last month, that's probably why it couldn't find the tag anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Notify user when a newer version of
act
is available. Support disabling of version check by setting environment variableACT_DISABLE_VERSION_CHECK=1