Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply forcePull only for prebuild docker actions #1599

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

ChristopherHX
Copy link
Contributor

Seems like forePull has been buggy in the past.
Tests should be added at a later time

Fixes #1594

@ChristopherHX ChristopherHX requested a review from a team as a code owner February 2, 2023 09:19
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.95s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 1.16s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #1599 (d740583) into master (4989f44) will increase coverage by 0.72%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
+ Coverage   61.22%   61.95%   +0.72%     
==========================================
  Files          46       46              
  Lines        7141     7188      +47     
==========================================
+ Hits         4372     4453      +81     
+ Misses       2462     2428      -34     
  Partials      307      307              
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 13.58% <ø> (ø)
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/runner/run_context.go 78.81% <0.00%> (ø)
pkg/container/docker_images.go 27.02% <29.41%> (-4.13%) ⬇️
pkg/container/docker_auth.go 51.35% <56.25%> (+3.73%) ⬆️
pkg/runner/runner.go 86.45% <66.66%> (-2.05%) ⬇️
pkg/common/git/git.go 57.72% <79.71%> (+7.72%) ⬆️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local workflow broken after ACT upgrade
3 participants