Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add GITHUB_STEP_SUMMARY #1607

Merged
merged 4 commits into from
Feb 23, 2023
Merged

fix: add GITHUB_STEP_SUMMARY #1607

merged 4 commits into from
Feb 23, 2023

Conversation

catthehacker
Copy link
Member

@catthehacker catthehacker commented Feb 4, 2023

Fixes #1533

Commit Message

{{title}} (#1607)

@catthehacker catthehacker requested a review from a team as a code owner February 4, 2023 16:44
@mergify
Copy link
Contributor

mergify bot commented Feb 4, 2023

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Feb 4, 2023
@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Merging #1607 (d44335f) into master (4989f44) will increase coverage by 0.87%.
The diff coverage is 70.04%.

@@            Coverage Diff             @@
##           master    #1607      +/-   ##
==========================================
+ Coverage   61.22%   62.09%   +0.87%     
==========================================
  Files          46       46              
  Lines        7141     7250     +109     
==========================================
+ Hits         4372     4502     +130     
+ Misses       2462     2440      -22     
- Partials      307      308       +1     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <ø> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/model/planner.go 44.71% <21.27%> (-4.12%) ⬇️
pkg/container/docker_images.go 27.02% <29.41%> (-4.13%) ⬇️
pkg/model/github_context.go 61.06% <32.00%> (-19.40%) ⬇️
... and 23 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

KnisterPeter
KnisterPeter previously approved these changes Feb 4, 2023
@ChristopherHX
Copy link
Contributor

I guess your trailing two tabs in every added empty line are trigger the lint failure. I approve, once this is resolved.

@mergify mergify bot added the conflict PR has conflicts label Feb 16, 2023
@mergify mergify bot removed the conflict PR has conflicts label Feb 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.95s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 1.17s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready for merge now, I removed trailing tabs and resolved the conflict

@mergify mergify bot removed the needs-work Extra attention is needed label Feb 16, 2023
@nektos nektos deleted a comment from mergify bot Feb 16, 2023
@nektos nektos deleted a comment from mergify bot Feb 16, 2023
@joanrodriguez
Copy link

Let's goooo let's merge this!

@mergify mergify bot merged commit 8790c9b into master Feb 23, 2023
@mergify mergify bot deleted the fix/github-step-summary branch February 23, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for >> $GITHUB_STEP_SUMMARY
5 participants