Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove obsolete Container.UpdateFromPath #1631

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

ChristopherHX
Copy link
Contributor

I have removed any references to this function in previous PR's, this just removes the unused code.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 4 0 0.02s
✅ REPOSITORY gitleaks yes no 2.51s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.88s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@ChristopherHX ChristopherHX marked this pull request as ready for review February 16, 2023 12:05
@ChristopherHX ChristopherHX requested a review from a team as a code owner February 16, 2023 12:05
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1631 (eac3982) into master (4989f44) will increase coverage by 1.04%.
The diff coverage is 75.30%.

@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
+ Coverage   61.22%   62.27%   +1.04%     
==========================================
  Files          46       46              
  Lines        7141     7204      +63     
==========================================
+ Hits         4372     4486     +114     
+ Misses       2462     2414      -48     
+ Partials      307      304       -3     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <ø> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/container/docker_images.go 27.02% <29.41%> (-4.13%) ⬇️
pkg/model/github_context.go 61.06% <32.00%> (-19.40%) ⬇️
pkg/container/docker_auth.go 51.35% <56.25%> (+3.73%) ⬆️
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 21ea3d0 into master Feb 16, 2023
@mergify mergify bot deleted the remove-obsolete-Container-UpdateFromPath branch February 16, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants