Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure using a safe name to store actions on unix-like and windows #1651

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

@wolfogre wolfogre requested a review from a team as a code owner February 27, 2023 10:51
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1651 (008e834) into master (4989f44) will increase coverage by 1.26%.
The diff coverage is 71.47%.

@@            Coverage Diff             @@
##           master    #1651      +/-   ##
==========================================
+ Coverage   61.22%   62.49%   +1.26%     
==========================================
  Files          46       48       +2     
  Lines        7141     7452     +311     
==========================================
+ Hits         4372     4657     +285     
- Misses       2462     2476      +14     
- Partials      307      319      +12     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <ø> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/model/workflow.go 42.11% <ø> (ø)
pkg/model/planner.go 44.71% <21.27%> (-4.12%) ⬇️
pkg/container/docker_images.go 27.02% <29.41%> (-4.13%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking more about this

This change guards us against

- uses: owner/repo/volunable?/test:/me@tag

I'm not shure why we include the path in the foldername
We clone the actions more often than needed

@wolfogre wolfogre changed the title Make sure using a safe name to store actions on unix-like and windows fix: make sure using a safe name to store actions on unix-like and windows Feb 28, 2023
@mergify mergify bot merged commit 19abab6 into nektos:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants