Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full path required for extension install #1670

Merged
merged 5 commits into from
Mar 20, 2023
Merged

Conversation

Mearman
Copy link
Contributor

@Mearman Mearman commented Mar 8, 2023

No description provided.

@Mearman Mearman requested a review from a team as a code owner March 8, 2023 11:39
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1670 (ab19941) into master (4989f44) will increase coverage by 1.63%.
The diff coverage is 74.20%.

@@            Coverage Diff             @@
##           master    #1670      +/-   ##
==========================================
+ Coverage   61.22%   62.85%   +1.63%     
==========================================
  Files          46       48       +2     
  Lines        7141     7479     +338     
==========================================
+ Hits         4372     4701     +329     
+ Misses       2462     2459       -3     
- Partials      307      319      +12     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <0.00%> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/model/workflow.go 42.11% <ø> (ø)
pkg/model/planner.go 44.71% <21.27%> (-4.12%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cplee
Copy link
Contributor

cplee commented Mar 8, 2023

Why is this change necessary? According to docs and local testing, the current instructions are valid:

https://cli.github.com/manual/gh_extension_install

@ChristopherHX
Copy link
Contributor

I would guess, that gh configured against https://GHES would look for https://GHES/nektos/gh-act.

Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some research it's true that we should use the full url.

If the owner and repository are used, gh will install the extension using the hostname to which gh is currently authenticated. The full URL format is useful when installing extensions from a different host. For example, users on GitHub Enterprise Server should use the full repository URL to install extensions from GitHub.com or any other host

Hostname doesn't have to be github.com,
src:
https://docs.github.com/en/[email protected]/github-cli/github-cli/using-github-cli-extensions#installing-extensions

@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2023

@Mearman this pull request has failed checks 🛠

@mergify mergify bot added needs-work Extra attention is needed and removed needs-work Extra attention is needed labels Mar 14, 2023
@cplee
Copy link
Contributor

cplee commented Mar 20, 2023

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023

refresh

✅ Pull request refreshed

@cplee cplee merged commit 9fab599 into nektos:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants