Make sure working directory is respected when configured from matrix

[krisgeus]

fixes #1685

[mergify]

@krisgeus this pull request has failed checks 🛠

[krisgeus]

@act-maintainers. The checks are failing but to mee it seem to be unrelated to my specific change. Unfortunately I wasn’t able to get the tests to run locally to verify.
Could you shed some light on this to help me figure out what I need to do to fix this?

[ChristopherHX]

Seems like this change cause regressions, maybe you skipped over some function reading workdir

Unfortunately I wasn’t able to get the tests to run locally to verify.

One error can be reproduced like, switching to act master fixes it

go build
./act -W ./pkg/runner/testdata/nix-prepend-path/push.yml -P self-hosted=-self-hosted

[krisgeus]

@ChristopherHX I see there is some kind of regression indeed. The test fails in my branch and not in master. I cannot figure out why and need help with that. I removed the unwanted side effect of setting the WorkingDirectory on the step (unwanted in the case of using a matrix) but it seems that this side effect is needed in regular cases.
I have searched the full codebase to see where WorkingDirectory is used and cannot find any other occurrences then the ones I touched already.
If you could help me out with this investigation it is much appreciated.

[codecov]

Codecov Report

Merging #1686 (3d7b363) into master (4989f44) will increase coverage by 1.60%.
The diff coverage is 74.52%.

@@            Coverage Diff             @@
##           master    #1686      +/-   ##
==========================================
+ Coverage   61.22%   62.83%   +1.60%     
==========================================
  Files          46       48       +2     
  Lines        7141     7482     +341     
==========================================
+ Hits         4372     4701     +329     
+ Misses       2462     2461       -1     
- Partials      307      320      +13     

Impacted Files	Coverage Δ
pkg/container/docker_cli.go	82.23% <ø> (ø)
pkg/container/docker_logger.go	52.08% <ø> (ø)
pkg/container/docker_pull.go	33.33% <ø> (ø)
pkg/container/docker_run.go	14.08% <0.00%> (+0.49%)	⬆️
pkg/container/docker_volume.go	0.00% <ø> (ø)
pkg/container/file_collector.go	37.30% <0.00%> (ø)
pkg/container/host_environment.go	0.00% <0.00%> (ø)
pkg/exprparser/functions.go	66.32% <0.00%> (-1.04%)	⬇️
pkg/model/workflow.go	42.11% <ø> (ø)
pkg/model/planner.go	44.71% <21.27%> (-4.12%)	⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ChristopherHX]

Looks good to me, thank you for contributing a fix.

[krisgeus]

Happy to be able to contribute. I updated the branch to match the latest master. Let me know if I need to do anything else to get this one merged.

[KnisterPeter]

Nice work. Thanks for your contribution 😃