Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cmd support for windows #1941

Merged
merged 3 commits into from
Aug 8, 2023
Merged

fix: cmd support for windows #1941

merged 3 commits into from
Aug 8, 2023

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Aug 1, 2023

The cmd seem to be not compatible with shellquote / golang argv handling. Also remove comspec from the shell template for cmd.

Related #1608

@ChristopherHX ChristopherHX requested a review from a team as a code owner August 1, 2023 19:33
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 4 0 0.05s
✅ REPOSITORY gitleaks yes no 3.9s
✅ REPOSITORY git_diff yes no 0.18s
✅ REPOSITORY grype yes no 10.35s
✅ REPOSITORY secretlint yes no 1.91s
✅ REPOSITORY trivy-sbom yes no 0.89s
✅ REPOSITORY trufflehog yes no 9.9s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2023

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Aug 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2023

@ChristopherHX this pull request has failed checks 🛠

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1941 (22affb5) into master (4989f44) will increase coverage by 1.09%.
Report is 218 commits behind head on master.
The diff coverage is 62.59%.

@@            Coverage Diff             @@
##           master    #1941      +/-   ##
==========================================
+ Coverage   61.22%   62.31%   +1.09%     
==========================================
  Files          46       51       +5     
  Lines        7141     8354    +1213     
==========================================
+ Hits         4372     5206     +834     
- Misses       2462     2746     +284     
- Partials      307      402      +95     
Files Changed Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
...ontainer/linux_container_environment_extensions.go 23.07% <0.00%> (-1.25%) ⬇️
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/container/docker_run.go 13.45% <7.14%> (-0.13%) ⬇️
... and 28 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Aug 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Aug 8, 2023
@mergify mergify bot removed the needs-work Extra attention is needed label Aug 8, 2023
@mergify mergify bot merged commit 8314095 into master Aug 8, 2023
10 checks passed
@mergify mergify bot deleted the cmd-support branch August 8, 2023 15:44
@ChristopherHX ChristopherHX mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants