Use unique name for reusable workflows #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is an example of the change that my pull request will make. When running With act v0.2.50. Note that all four matrix jobs have the same name: With this pull request. Note the unique digit added to each iteration of |
Codecov Report
@@ Coverage Diff @@
## master #2015 +/- ##
==========================================
+ Coverage 61.22% 61.41% +0.19%
==========================================
Files 46 53 +7
Lines 7141 8779 +1638
==========================================
+ Hits 4372 5392 +1020
- Misses 2462 2957 +495
- Partials 307 430 +123
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
ChristopherHX
approved these changes
Nov 12, 2023
| @@ -64,7 +64,7 @@ func (rc *RunContext) String() string { | |||
| if rc.caller != nil { | |||
| // prefix the reusable workflow with the caller job | |||
| // this is required to create unique container names | |||
| name = fmt.Sprintf("%s/%s", rc.caller.runContext.Run.JobID, name) | |||
| name = fmt.Sprintf("%s/%s", rc.caller.runContext.Name, name) | |||
There was a problem hiding this comment.
It's still not unique (e.g. matrix?), but should have less conflicts
cplee
approved these changes
Nov 12, 2023
jmikedupont2
pushed a commit
to meta-introspector/act
that referenced
this pull request
Mar 10, 2024
Co-authored-by: ChristopherHX <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use unique name for reusable workflows.
Fixes #2003 - act does not create separate containers for matrix builds with reusable workflows.