Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Variables ] - Add missing documentation for repository variables #2032

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

sousadiego11
Copy link
Contributor

@sousadiego11 sousadiego11 commented Sep 29, 2023

As seen in this issue the support for variables was made months ago, but the documentation does not have this information

Why update this: at least for me, the only way to discover this functionality existed was searching and finding the mentioned issue above

Reference for the updated section:
image

@sousadiego11 sousadiego11 requested a review from a team as a code owner September 29, 2023 18:00
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2032 (b1e5d06) into master (4989f44) will increase coverage by 0.82%.
Report is 246 commits behind head on master.
The diff coverage is 61.96%.

@@            Coverage Diff             @@
##           master    #2032      +/-   ##
==========================================
+ Coverage   61.22%   62.05%   +0.82%     
==========================================
  Files          46       52       +6     
  Lines        7141     8488    +1347     
==========================================
+ Hits         4372     5267     +895     
- Misses       2462     2800     +338     
- Partials      307      421     +114     
Files Coverage Δ
pkg/common/executor.go 51.69% <100.00%> (+1.69%) ⬆️
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/runner/job_executor.go 88.48% <100.00%> (+0.79%) ⬆️
pkg/runner/step_action_local.go 93.54% <100.00%> (ø)
pkg/runner/step_action_remote.go 91.56% <100.00%> (+0.65%) ⬆️
pkg/runner/step_docker.go 93.18% <100.00%> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/container/docker_build.go 60.00% <80.00%> (+1.02%) ⬆️
... and 30 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 5718555 into nektos:master Oct 3, 2023
10 checks passed
jmikedupont2 pushed a commit to meta-introspector/act that referenced this pull request Mar 10, 2024
…ektos#2032)

* docs: 📝 add vars instructions by cli and file loading

* docs: 📝 adjust varibles instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants