Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve warning about remote not found #2169

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 28, 2024

fixes #1546

@jsoref jsoref requested a review from a team as a code owner January 28, 2024 03:59
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 1033 lines in your changes are missing coverage. Please review.

Comparison is base (4989f44) 61.22% compared to head (6059458) 60.97%.
Report is 310 commits behind head on master.

Files Patch % Lines
pkg/artifactcache/handler.go 65.32% 103 Missing and 43 partials ⚠️
pkg/runner/run_context.go 73.37% 75 Missing and 19 partials ⚠️
pkg/runner/expression.go 55.17% 66 Missing and 12 partials ⚠️
pkg/runner/action_cache.go 50.00% 51 Missing and 17 partials ⚠️
pkg/container/docker_run.go 1.47% 66 Missing and 1 partial ⚠️
pkg/container/docker_network.go 0.00% 56 Missing ⚠️
pkg/model/planner.go 28.57% 53 Missing and 2 partials ⚠️
pkg/model/workflow.go 52.72% 42 Missing and 10 partials ⚠️
pkg/runner/reusable_workflow.go 52.47% 42 Missing and 6 partials ⚠️
pkg/common/outbound_ip.go 0.00% 44 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2169      +/-   ##
==========================================
- Coverage   61.22%   60.97%   -0.25%     
==========================================
  Files          46       53       +7     
  Lines        7141     9002    +1861     
==========================================
+ Hits         4372     5489    +1117     
- Misses       2462     3074     +612     
- Partials      307      439     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, better error messages are really needed in my opinion

Copy link
Contributor

mergify bot commented Jan 28, 2024

@jsoref this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jan 28, 2024
Copy link
Contributor

mergify bot commented Jan 28, 2024

@jsoref this pull request has failed checks 🛠

@jsoref
Copy link
Contributor Author

jsoref commented Jan 28, 2024

I don't think the build failure is my fault

@mergify mergify bot removed the needs-work Extra attention is needed label Jan 28, 2024
@mergify mergify bot merged commit 5e0d29d into nektos:master Jan 28, 2024
10 checks passed
@ChristopherHX
Copy link
Contributor

I don't think the build failure is my fault

yes I had to press rerun twice, due to two different flaky tests and it worked.

@jsoref jsoref deleted the issue-1546 branch January 28, 2024 21:53
jmikedupont2 pushed a commit to meta-introspector/act that referenced this pull request Mar 10, 2024
Signed-off-by: Josh Soref <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to find git repo
3 participants