-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip service container for empty image #2281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I dislike the codecov action, but are too lazy / unable to generate a token and refactor the workflow |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2281 +/- ##
===========================================
+ Coverage 61.56% 76.32% +14.76%
===========================================
Files 53 61 +8
Lines 9002 7815 -1187
===========================================
+ Hits 5542 5965 +423
+ Misses 3020 1295 -1725
- Partials 440 555 +115 ☔ View full report in Codecov by Sentry. |
@GitBluub this pull request has failed checks 🛠 |
@GitBluub this pull request has failed checks 🛠 |
I really need to fix the pipeline, waiting 15min to see that failure randomly is so bad... (I'm not authorized to merge without all checks green and another reviewer) |
@GitBluub this pull request has failed checks 🛠 |
2 similar comments
@GitBluub this pull request has failed checks 🛠 |
@GitBluub this pull request has failed checks 🛠 |
It is used to skip empty image name in services which is the only way to handle condition services in github action currently actions/runner#822
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing tests
It is used to skip empty image name in services which is the only way to handle conditional services in github action currently, see actions/runner#822
Prints the same information message as well