-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2363. Add /pre- and /post-entrypoint handling #2394
Fix #2363. Add /pre- and /post-entrypoint handling #2394
Conversation
@AndriiChyrva this pull request has failed checks 🛠 |
Thank you, I will look into the failing workflows in ca. 8 days and help you to resolve them There might be some regressions in this PR or tests testing the wrong thing |
Awesome! Thank you for support. |
@AndriiChyrva this pull request has failed checks 🛠 |
I found one issue where you probably did copy paste from the pre to the post condition where pre has not been replaced by post |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2394 +/- ##
===========================================
+ Coverage 61.56% 76.47% +14.91%
===========================================
Files 53 61 +8
Lines 9002 7919 -1083
===========================================
+ Hits 5542 6056 +514
+ Misses 3020 1307 -1713
- Partials 440 556 +116 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me now, all tests are passing.
I might not have tested the new feature itself, more looked at the broken tests and fixed the logic error
Fix #2363. Add /pre- and /post-entrypoint handling