fix GOOS parsing to match expected GHA RUNNER_OS values #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github actions reports RUNNER_OS for linux and windows with capital letters (Linux, Windows). This should increase compatibility when runner uses `-self-hosted`
wolfogre
approved these changes
Aug 13, 2024
|
@benniekiss this pull request has failed checks 🛠 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2422 +/- ##
===========================================
+ Coverage 61.56% 76.57% +15.01%
===========================================
Files 53 62 +9
Lines 9002 8159 -843
===========================================
+ Hits 5542 6248 +706
+ Misses 3020 1345 -1675
- Partials 440 566 +126 ☔ View full report in Codecov by Sentry. |
|
@benniekiss this pull request has failed checks 🛠 |
ChristopherHX
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github actions reports RUNNER_OS for linux and windows with capital letters (Linux, Windows). This should increase compatibility when runner uses
-self-hostedCurrently, when workflows are run within containers, RUNNER_OS is hardcoded to
Linuxcorrectly, so this will make RUNNER_OS more consistent.Closes #1990