Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to run custom architecture (container platform) #525

Merged
merged 4 commits into from
Mar 29, 2021
Merged

Add option to run custom architecture (container platform) #525

merged 4 commits into from
Mar 29, 2021

Conversation

catthehacker
Copy link
Member

Closes #493

@catthehacker catthehacker force-pushed the container-platform branch 3 times, most recently from c42bde4 to 5fd0b5e Compare February 8, 2021 22:40
@catthehacker
Copy link
Member Author

Ok, I have currently no idea where it fails...

@catthehacker
Copy link
Member Author

catthehacker commented Feb 10, 2021 •
edited
Loading

Current test will fail as it's dependent on #524
https://github.com/nektos/act/pull/525/checks#step:5:6360

@catthehacker catthehacker mentioned this pull request Mar 2, 2021
Closed
@catthehacker catthehacker changed the title Add option to run custom container platform Add option to run custom architecture (container platform) Mar 5, 2021
@catthehacker
Copy link
Member Author

@cplee Let me know if there is anything wrong.
I've also renamed the parameter lately to --container-architecture since platform could be confused with -P, --platform stringArray custom image to use per platform.
Whenever it's mentioned in act context it's containerArchitecture and when it touches Docker API it's Platform.

@cplee cplee merged commit 6c258cf into nektos:master Mar 29, 2021
@cplee cplee added the needs-work Extra attention is needed label Mar 29, 2021
@catthehacker catthehacker deleted the container-platform branch March 29, 2021 12:39
ZauberNerd
ZauberNerd reviewed Apr 15, 2021
View reviewed changes
pkg/runner/step_context.go
Comment on lines +388 to +390
if !exists {
return err
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code always exits here with err nil and the code below won't get executed, which causes local docker actions to be skipped.
This is caused by container.NewDockerBuildExecutor returning a function which is not executed here, but in line 483.
/cc @catthehacker @cplee

@Totktonada Totktonada mentioned this pull request Apr 19, 2021
Closed
5 tasks
@Totktonada Totktonada mentioned this pull request Jul 28, 2021
Merged
@catthehacker catthehacker removed the needs-work Extra attention is needed label Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZauberNerd ZauberNerd ZauberNerd left review comments

@cplee cplee cplee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable specifying docker --platform argument
3 participants
@catthehacker @ZauberNerd @cplee