Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update readme with more relevant/updated information #630

Merged
merged 1 commit into from
May 3, 2021

Conversation

catthehacker
Copy link
Member

@catthehacker catthehacker commented Apr 23, 2021

hi @cplee, could you check the PR and let me know how it looks?
Making it as draft since I will be updating it today/tomorrow still, just pushing it for visibility

Fixes #623
Supersedes #616
Continuation of #367

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #630 (0578440) into master (f32babb) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 0578440 differs from pull request most recent head a652df8. Consider uploading reports for the commit a652df8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   49.39%   49.35%   -0.05%     
==========================================
  Files          23       23              
  Lines        2318     2320       +2     
==========================================
  Hits         1145     1145              
- Misses       1046     1049       +3     
+ Partials      127      126       -1     
Impacted Files Coverage Δ
pkg/runner/step_context.go 70.40% <0.00%> (-0.54%) ⬇️
pkg/runner/run_context.go 77.55% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32babb...a652df8. Read the comment docs.

@catthehacker
Copy link
Member Author

README or IMAGES should have more information about included software in the images.
ref: #632

@catthehacker catthehacker marked this pull request as ready for review May 3, 2021 01:10
Copy link
Contributor

@cplee cplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this ❤️

@cplee cplee merged commit 08141f5 into nektos:master May 3, 2021
@catthehacker catthehacker deleted the readme-update branch May 7, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Update docs on Apple Silicon support
2 participants