Add super-linter + fix lint issues
#650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catthehacker
requested review from
a team and
cplee
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #650 +/- ##
==========================================
+ Coverage 49.59% 49.66% +0.06%
==========================================
Files 23 23
Lines 2365 2370 +5
==========================================
+ Hits 1173 1177 +4
- Misses 1066 1067 +1
Partials 126 126
Continue to review full report at Codecov.
|
Bump `golangci-lint` version. Add `super-linter` to lint other languages. Go linter is disabled because it's currently broken: https://github.com/github/super-linter/pull/370 Replacing `scopelint` with `exportloopref`: "[runner] The linter 'scopelint' is deprecated (since v1.39.0) due to: The repository of the linter has been deprecated by the owner. Replaced by exportloopref." Fixed formatting in `.golangci.yml` Add addtional linters: `misspell`: purely style, detects typos in comments `whitespace`: detects leading and trailing whitespace `goimports`: it's gofmt + checks unused imports
catthehacker
force-pushed
the
golangci-lint
branch
from
dc4eff2
to
62964cb
Compare
|
thanks @catthehacker for the quick save 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
super-linterto lint other languages.Go linter is disabled because it's currently broken:
https://github.com/github/super-linter/pull/370
Replacing
scopelintwithexportloopref: "[runner] The linter'scopelint' is deprecated (since v1.39.0) due to: The repository of the
linter has been deprecated by the owner. Replaced by exportloopref."
Fixed formatting in
.golangci.ymlAdd addtional linters:
misspell: purely style, detects typos in commentswhitespace: detects leading and trailing whitespacegoimports: it's gofmt + checks unused imports