Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Windows issue from README.md #675

Merged

Conversation

catthehacker
Copy link
Member

It's fixed already 🎉

@catthehacker catthehacker requested a review from a team as a code owner May 6, 2021 17:12
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #675 (e078fa0) into master (0f04942) will increase coverage by 0.72%.
The diff coverage is 61.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   49.27%   50.00%   +0.72%     
==========================================
  Files          23       23              
  Lines        2401     2518     +117     
==========================================
+ Hits         1183     1259      +76     
- Misses       1090     1124      +34     
- Partials      128      135       +7     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.82% <0.00%> (-0.11%) ⬇️
pkg/common/git.go 55.88% <5.00%> (-3.92%) ⬇️
pkg/model/workflow.go 30.71% <33.33%> (+5.00%) ⬆️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 71.71% <72.64%> (+2.76%) ⬆️
pkg/runner/run_context.go 77.54% <94.54%> (+1.14%) ⬆️
pkg/runner/runner.go 76.92% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a144e71...e078fa0. Read the comment docs.

@mergify
Copy link
Contributor

mergify bot commented May 6, 2021

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label May 6, 2021
@cplee cplee merged commit cc4e23d into nektos:master May 6, 2021
@catthehacker catthehacker deleted the cat/fix/remove-windows-issue-readme branch May 20, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work Extra attention is needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants