Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support container removal at exit. Fixes #694 #714

Merged
merged 3 commits into from
Jun 10, 2021

Conversation

jbenden
Copy link
Contributor

@jbenden jbenden commented Jun 1, 2021

This patch adds a new command-line flag (--rm) to automatically
stop workflow container(s), just prior to exit. The default
behavior is kept, e.g.: the containers continue running at exit.

Fixes: #694
Signed-off-by: Joseph Benden [email protected]

@jbenden jbenden requested a review from a team as a code owner June 1, 2021 16:50
@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2021

@jbenden this pull request is now in conflict 😩

@mergify mergify bot added the conflict PR has conflicts label Jun 4, 2021
@mergify mergify bot removed the conflict PR has conflicts label Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #714 (bf4194e) into master (0f04942) will increase coverage by 0.51%.
The diff coverage is 53.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
+ Coverage   49.27%   49.78%   +0.51%     
==========================================
  Files          23       23              
  Lines        2401     2575     +174     
==========================================
+ Hits         1183     1282      +99     
- Misses       1090     1150      +60     
- Partials      128      143      +15     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.84% <0.00%> (-0.09%) ⬇️
pkg/model/workflow.go 25.29% <2.43%> (-0.43%) ⬇️
pkg/common/git.go 53.08% <30.15%> (-6.72%) ⬇️
pkg/runner/runner.go 68.96% <33.33%> (-7.51%) ⬇️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 72.05% <71.85%> (+3.11%) ⬆️
pkg/runner/run_context.go 79.84% <95.52%> (+3.44%) ⬆️
pkg/runner/command.go 90.58% <100.00%> (+2.35%) ⬆️
pkg/runner/logger.go 64.81% <100.00%> (+0.66%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2261204...bf4194e. Read the comment docs.

@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2021

@jbenden this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jun 4, 2021
This patch adds a new command-line flag (`--rm`) to automatically
stop workflow container(s), just prior to exit. The default
behavior is kept, e.g.: the containers continue running at exit.

Fixes: nektos#694
Signed-off-by: Joseph Benden <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2021

@jbenden this pull request has failed checks 🛠

@jbenden
Copy link
Contributor Author

jbenden commented Jun 4, 2021

I think the failure is caused by something external to the changes in this PR. Could someone help confirm this? Thanks!

@catthehacker
Copy link
Member

It's due to DockerHub pull limit. I'm working on fixing that

@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2021

@jbenden this pull request has failed checks 🛠

@mergify mergify bot removed the needs-work Extra attention is needed label Jun 9, 2021
@catthehacker
Copy link
Member

🎉

@mergify mergify bot requested a review from a team June 10, 2021 13:46
@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2021

@jbenden this pull request has failed checks 🛠

@mergify mergify bot added needs-work Extra attention is needed and removed needs-work Extra attention is needed labels Jun 10, 2021
@mergify mergify bot merged commit 003c995 into nektos:master Jun 10, 2021
catthehacker pushed a commit to catthehacker/act-fork that referenced this pull request Nov 14, 2021
Adds option to rebuild local action docker images
which is enabled by default

Fixed up README due to missing flags after
PR nektos#714 and nektos#716

Signed-off-by: hackercat <[email protected]>
catthehacker pushed a commit to catthehacker/act-fork that referenced this pull request Nov 22, 2021
Adds option to rebuild local action docker images
which is enabled by default

Fixed up README due to missing flags after
PR nektos#714 and nektos#716

Signed-off-by: hackercat <[email protected]>
catthehacker pushed a commit to catthehacker/act-fork that referenced this pull request Nov 22, 2021
Adds option to rebuild local action docker images

Fixed up README due to missing flags after
PR nektos#714 and nektos#716

Signed-off-by: hackercat <[email protected]>
cplee pushed a commit that referenced this pull request Nov 24, 2021
Adds option to rebuild local action docker images

Fixed up README due to missing flags after
PR #714 and #716

Signed-off-by: hackercat <[email protected]>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Container keeps running after exit
3 participants