-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support container removal at exit. Fixes #694 #714
Conversation
@jbenden this pull request is now in conflict 😩 |
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
==========================================
+ Coverage 49.27% 49.78% +0.51%
==========================================
Files 23 23
Lines 2401 2575 +174
==========================================
+ Hits 1183 1282 +99
- Misses 1090 1150 +60
- Partials 128 143 +15
Continue to review full report at Codecov.
|
@jbenden this pull request has failed checks 🛠 |
This patch adds a new command-line flag (`--rm`) to automatically stop workflow container(s), just prior to exit. The default behavior is kept, e.g.: the containers continue running at exit. Fixes: nektos#694 Signed-off-by: Joseph Benden <[email protected]>
@jbenden this pull request has failed checks 🛠 |
I think the failure is caused by something external to the changes in this PR. Could someone help confirm this? Thanks! |
It's due to DockerHub pull limit. I'm working on fixing that |
@jbenden this pull request has failed checks 🛠 |
🎉 |
@jbenden this pull request has failed checks 🛠 |
Adds option to rebuild local action docker images which is enabled by default Fixed up README due to missing flags after PR nektos#714 and nektos#716 Signed-off-by: hackercat <[email protected]>
Adds option to rebuild local action docker images which is enabled by default Fixed up README due to missing flags after PR nektos#714 and nektos#716 Signed-off-by: hackercat <[email protected]>
Adds option to rebuild local action docker images Fixed up README due to missing flags after PR nektos#714 and nektos#716 Signed-off-by: hackercat <[email protected]>
Adds option to rebuild local action docker images Fixed up README due to missing flags after PR #714 and #716 Signed-off-by: hackercat <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This patch adds a new command-line flag (
--rm
) to automaticallystop workflow container(s), just prior to exit. The default
behavior is kept, e.g.: the containers continue running at exit.
Fixes: #694
Signed-off-by: Joseph Benden [email protected]