Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh hash after pull for branch refs #791

Merged

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Aug 30, 2021

TODO verify if this fixes #785 Done.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #791 (a86f728) into master (0f04942) will increase coverage by 4.62%.
The diff coverage is 62.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   49.27%   53.90%   +4.62%     
==========================================
  Files          23       23              
  Lines        2401     2679     +278     
==========================================
+ Hits         1183     1444     +261     
+ Misses       1090     1088       -2     
- Partials      128      147      +19     
Impacted Files Coverage Δ
pkg/container/docker_build.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 1.77% <0.00%> (-0.16%) ⬇️
pkg/common/git.go 52.55% <30.88%> (-7.24%) ⬇️
pkg/runner/runner.go 68.96% <33.33%> (-7.51%) ⬇️
pkg/model/planner.go 52.14% <43.33%> (+19.06%) ⬆️
pkg/model/workflow.go 51.08% <62.68%> (+25.37%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/expression.go 85.38% <71.87%> (-1.26%) ⬇️
pkg/runner/step_context.go 78.92% <79.90%> (+9.97%) ⬆️
pkg/runner/run_context.go 80.36% <98.55%> (+3.95%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a2659...a86f728. Read the comment docs.

@ChristopherHX ChristopherHX marked this pull request as ready for review September 2, 2021 19:02
@ChristopherHX ChristopherHX requested a review from a team as a code owner September 2, 2021 19:02
@ChristopherHX
Copy link
Contributor Author

I merged this change into my fork and verified the original issue will be fixed by this small change.

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2021

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Sep 2, 2021
@mergify mergify bot removed the needs-work Extra attention is needed label Sep 2, 2021
@mergify mergify bot requested a review from a team September 8, 2021 14:58
@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2021

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added needs-work Extra attention is needed and removed needs-work Extra attention is needed labels Sep 8, 2021
@mergify mergify bot merged commit f0fd0af into nektos:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: act does not update actions if version is taken from branch
3 participants