Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace superlinter with megalinter #923

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

catthehacker
Copy link
Member

@catthehacker catthehacker commented Dec 11, 2021

  • replaced https://github.com/github/super-linter with https://github.com/megalinter/megalinter (megalinter is maintained better than superlinter)
  • pass context to Executor for gitClone, this was recommended by contextcheck linter but later on I noticed it's a required
    fix anyway for logging, also pass context to Docker engine version check func
  • fix .goreleaser.yml, in-editor schema validation (and schema linter) screams about ints being ints
  • correct dependabot.yml quotes
  • move CGO_ENABLED to global env
  • remove unnecessary nolint comments

@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #923 (f0a2e36) into master (0f04942) will increase coverage by 7.55%.
The diff coverage is 63.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   49.27%   56.82%   +7.55%     
==========================================
  Files          23       28       +5     
  Lines        2401     4160    +1759     
==========================================
+ Hits         1183     2364    +1181     
- Misses       1090     1589     +499     
- Partials      128      207      +79     
Impacted Files Coverage Δ
pkg/common/executor.go 46.90% <0.00%> (+2.03%) ⬆️
pkg/common/job_error.go 0.00% <0.00%> (ø)
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/common/testflag.go 0.00% <0.00%> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <ø> (ø)
pkg/container/docker_run.go 5.54% <14.15%> (+3.61%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/runner/logger.go 65.43% <37.50%> (+1.28%) ⬆️
pkg/container/docker_auth.go 45.00% <45.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adabf2a...f0a2e36. Read the comment docs.

@catthehacker catthehacker marked this pull request as ready for review December 22, 2021 17:02
@catthehacker catthehacker requested a review from a team as a code owner December 22, 2021 17:02
@catthehacker catthehacker requested a review from a team December 22, 2021 17:02
@cplee
Copy link
Contributor

cplee commented Dec 22, 2021

Thanks for the quick fix @catthehacker

@cplee cplee merged commit 9be6a58 into nektos:master Dec 22, 2021
@catthehacker catthehacker deleted the cat/feat/megalinter branch December 22, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants