fix: always execute closeContainer() executor #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During our earlier refactoring in nektos#984 we accidentally changed the behaviour in such a way that the `closeContainer()` executor was never called. This commit restores the earlier behaviour. Ref: * https://github.com/nektos/act/pull/984/files#diff-c057d66dc9657d8428e290c69871596e2b567bb8fecad62a99cab54398131a84L294 * https://github.com/nektos/act/pull/984/files#diff-ea9d5c93d769ef9b268932dd9990363e97fc3bec8a00114979d049bead5dd718R68
This commit adds tests to ensure that the executors of `startContainer`, `stopContainer`, `interpolateOutputs` and `closeContainer` are always called in the correct order.
|
@ZauberNerd this pull request has failed checks 🛠 |
ZauberNerd
force-pushed
the
fix-jobexecutor-refactoring
branch
from
fd84c2a
to
5bba913
Compare
Codecov Report
@@ Coverage Diff @@
## master #988 +/- ##
==========================================
+ Coverage 57.50% 58.24% +0.73%
==========================================
Files 32 34 +2
Lines 4594 4615 +21
==========================================
+ Hits 2642 2688 +46
+ Misses 1729 1703 -26
- Partials 223 224 +1
Continue to review full report at Codecov.
|
ChristopherHX
approved these changes
Feb 10, 2022
catthehacker
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our earlier refactoring in #984 we accidentally changed the
behaviour in such a way that the
closeContainer()executor was nevercalled.
This commit restores the earlier behaviour and adds test cases for this regression.
Ref: