Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes on timeseries data to Keras example #151

Merged
merged 3 commits into from
May 15, 2020
Merged

Add notes on timeseries data to Keras example #151

merged 3 commits into from
May 15, 2020

Conversation

drasmuss
Copy link
Member

@drasmuss drasmuss commented May 4, 2020

Also added a bit more information to the Converter verification failure error message, and fixed a bug in the logging messages I discovered while looking at this.

@hunse
Copy link
Collaborator

hunse commented May 14, 2020

I found that test_logging didn't actually format the log messages, i.e. if the format specifiers in a message didn't match the arguments, it wouldn't catch it. So I added the loop at the end to format all the log messages, and make sure they're non-empty. If this looks good to you @drasmuss, I'll merge when the tests pass.

@drasmuss
Copy link
Member Author

Looks good

@hunse hunse merged commit c73cbee into master May 15, 2020
@hunse hunse deleted the conv-example branch May 15, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants