Update to support core SimPES changes #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drasmuss
force-pushed
the
fix-pes-encoders
branch
4 times, most recently
from
9e1e3eb
to
f223781
Compare
hunse
reviewed
Sep 23, 2020
hunse
reviewed
Sep 23, 2020
hunse
reviewed
Sep 23, 2020
| @@ -1230,16 +1230,18 @@ def special_set(s, op): | |||
| # reshape view | |||
| self.signals[sig] = self.signals[sig.base].reshape(sig.shape) | |||
| else: | |||
| # slice view | |||
|
|
|||
| if sig.shape[1:] != sig.base.shape[1:]: | |||
| # TODO: support this? | |||
| raise NotImplementedError("Slicing on axes > 0 is not supported") | |||
There was a problem hiding this comment.
I don't think it would be too hard to do this, and with the code below getting more complicated, it might actually be clearer just to implement it. That is, unless there's some underlying reason TensorFlow can't support it?
Doesn't have to happen in this PR, but something to keep in mind.
There was a problem hiding this comment.
If there were any other situations where this functionality was used then I'd probably look into implementing this at that point, but as long as it's only used in SimPES it seems easier to just special-case it there.
hunse
force-pushed
the
fix-pes-encoders
branch
from
aa6cf5d
to
7c9e1bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an error if advanced indexing is used, and fix the same bug found in nengo core (when applying PES learning on a neuron-to-neuron connection with a post slice).