Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase minimum keras-spiking version to 0.3 #219

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Increase minimum keras-spiking version to 0.3 #219

merged 1 commit into from
Nov 10, 2021

Conversation

drasmuss
Copy link
Member

@drasmuss drasmuss commented Nov 9, 2021

I don't think it's worth trying to be backwards compatible here, since it's an optional dependency.

tbekolay
tbekolay approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Agree that we don't need backwards compat.

@drasmuss drasmuss merged commit 5634591 into master Nov 10, 2021
@drasmuss drasmuss deleted the fix-keras-spiking branch November 10, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbekolay tbekolay tbekolay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drasmuss @tbekolay