-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Component Interface #829
base: master
Are you sure you want to change the base?
Conversation
@rsimmons1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @drasmuss, @jgosmann and @tcstewar to be potential reviewers. |
Nice! One bug just from initial playing around: It I make a new object, it will place it inside a sub-Network if the initial click is inside that Network, but if the release location is outside the Network then the object will be drawn such that it looks to be outside the Network, when it's really inside it. |
hmm interesting, I am pretty sure i know what happening there and should be able to fix it. |
This PR includes the new interface for drawing components, as well as a basic configure menu for ensembles and the ability to delete components.
The design is loosely based off google draw in terms of the drag to draw interaction.
Several design components are a temporary implementation including.
However, these are all fully functional.
The rest seems good, really just looking for feedback on the look and feel of the new interface, please mention anything that feels awkward or is missing. Thanks for reviewing!
As well, I'm currently going through the code styling and commenting this PR is just meant for people to try out.