-
Notifications
You must be signed in to change notification settings - Fork 493
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
… errors instead of throwing them, leaving half-created results (#2845)
- Loading branch information
Showing
5 changed files
with
186 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107 changes: 107 additions & 0 deletions
107
core/src/test/java/apoc/refactor/GraphRefactoringEnterpriseTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| package apoc.refactor; | ||
|
|
||
| import apoc.util.Neo4jContainerExtension; | ||
| import apoc.util.TestUtil; | ||
| import org.junit.AfterClass; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
| import org.neo4j.driver.Record; | ||
| import org.neo4j.driver.Session; | ||
| import org.neo4j.driver.internal.value.NullValue; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import static apoc.refactor.GraphRefactoringTest.CLONE_NODES_QUERY; | ||
| import static apoc.refactor.GraphRefactoringTest.CLONE_SUBGRAPH_QUERY; | ||
| import static apoc.refactor.GraphRefactoringTest.EXTRACT_QUERY; | ||
| import static apoc.util.TestContainerUtil.createEnterpriseDB; | ||
| import static apoc.util.TestContainerUtil.testCall; | ||
| import static apoc.util.TestUtil.isRunningInCI; | ||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNull; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assume.assumeFalse; | ||
| import static org.junit.Assume.assumeNotNull; | ||
| import static org.junit.Assume.assumeTrue; | ||
|
|
||
| public class GraphRefactoringEnterpriseTest { | ||
| private static final String CREATE_REL_FOR_EXTRACT_NODE = "CREATE (:Start)-[r:TO_MOVE {name: 'foobar', surname: 'baz'}]->(:End)"; | ||
| private static final String DELETE_REL_FOR_EXTRACT_NODE = "MATCH p=(:Start)-[r:TO_MOVE]->(:End) DELETE p"; | ||
| private static Neo4jContainerExtension neo4jContainer; | ||
| private static Session session; | ||
|
|
||
| @BeforeClass | ||
| public static void beforeAll() { | ||
| neo4jContainer = createEnterpriseDB(true); | ||
| neo4jContainer.start(); | ||
| session = neo4jContainer.getSession(); | ||
| } | ||
|
|
||
| @AfterClass | ||
| public static void afterAll() { | ||
| session.close(); | ||
| neo4jContainer.close(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCloneNodesWithNodeKeyConstraint() { | ||
| nodeKeyCommons(CLONE_NODES_QUERY); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCloneNodesWithBothExistenceAndUniqueConstraint() { | ||
| uniqueNotNullCommons(CLONE_NODES_QUERY); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCloneSubgraphWithNodeKeyConstraint() { | ||
| nodeKeyCommons(CLONE_SUBGRAPH_QUERY); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCloneSubgraphWithBothExistenceAndUniqueConstraint() { | ||
| uniqueNotNullCommons(CLONE_SUBGRAPH_QUERY); | ||
| } | ||
|
|
||
| @Test | ||
| public void testExtractNodesWithNodeKeyConstraint() { | ||
| session.writeTransaction(tx -> tx.run(CREATE_REL_FOR_EXTRACT_NODE)); | ||
| nodeKeyCommons(EXTRACT_QUERY); | ||
| session.writeTransaction(tx -> tx.run(DELETE_REL_FOR_EXTRACT_NODE)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testExtractNodesWithBothExistenceAndUniqueConstraint() { | ||
| session.writeTransaction(tx -> tx.run(CREATE_REL_FOR_EXTRACT_NODE)); | ||
| uniqueNotNullCommons(EXTRACT_QUERY); | ||
| session.writeTransaction(tx -> tx.run(DELETE_REL_FOR_EXTRACT_NODE)); | ||
| } | ||
|
|
||
| private void nodeKeyCommons(String query) { | ||
| session.writeTransaction(tx -> tx.run("CREATE CONSTRAINT nodeKey FOR (p:MyBook) REQUIRE (p.name, p.surname) IS NODE KEY")); | ||
| cloneNodesAssertions(query, "already exists with label `MyBook` and properties `name` = 'foobar', `surname` = 'baz'"); | ||
| session.writeTransaction(tx -> tx.run("DROP CONSTRAINT nodeKey")); | ||
|
|
||
| } | ||
|
|
||
| private void uniqueNotNullCommons(String query) { | ||
| session.writeTransaction(tx -> tx.run("CREATE CONSTRAINT unique FOR (p:MyBook) REQUIRE (p.name) IS UNIQUE")); | ||
| session.writeTransaction(tx -> tx.run("CREATE CONSTRAINT notNull FOR (p:MyBook) REQUIRE (p.name) IS NOT NULL")); | ||
|
|
||
| cloneNodesAssertions(query, "already exists with label `MyBook` and property `name` = 'foobar'"); | ||
| session.writeTransaction(tx -> tx.run("DROP CONSTRAINT unique")); | ||
| session.writeTransaction(tx -> tx.run("DROP CONSTRAINT notNull")); | ||
| } | ||
|
|
||
| private void cloneNodesAssertions(String query, String message) { | ||
| session.writeTransaction(tx -> tx.run("CREATE (n:MyBook {name: 'foobar', surname: 'baz'})")); | ||
| testCall(session, query, | ||
| r -> { | ||
| final String error = (String) r.get("error"); | ||
| assertTrue(error.contains(message)); | ||
| assertNull(r.get("output")); | ||
|
|
||
| }); | ||
| session.writeTransaction(tx -> tx.run("MATCH (n:MyBook) DELETE n")); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters