Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecurityContext.allowExecuteAdminProcedure is changing in 4.4 #1872

Merged

Conversation

mnd999
Copy link
Contributor

@mnd999 mnd999 commented Apr 27, 2021

Fixes #<Replace with the number of the issue, Mandatory>

SecurityContext.allowExecuteAdminProcedure is changing in 4.4 to provide more information than just true / false.

Proposed Changes (Mandatory)

  • Update to reflect this change to the interface .
  • I haven't done so, but it would be possible to use this to provide a better error message if this is desirable.

@fbiville
Copy link
Contributor

fbiville commented May 27, 2021

@mnd999 is this PR still needed?
EDIT on 2021-06-11: yes

@mnd999 mnd999 changed the title SecurityContext.allowExecuteAdminProcedure is changing in 4.3 SecurityContext.allowExecuteAdminProcedure is changing in 4.4 Jun 3, 2021
@mnd999 mnd999 changed the base branch from 4.3 to dev June 3, 2021 14:53
…ide more information than just true / false. Update to reflect this. I haven't done so, but it would be possible to use this to provide a better error message if this is desirable.
@mnd999 mnd999 force-pushed the 4.3-securityContext-adminproc-fix branch from d121a3c to 8d49d87 Compare June 11, 2021 08:09
@mnd999 mnd999 marked this pull request as ready for review June 11, 2021 10:46
@fbiville fbiville merged commit 4be608b into neo4j-contrib:dev Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants