Replace usage of removed db.indexes() with SHOW INDEXES #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lojjs
approved these changes
Nov 16, 2021
jexp
reviewed
Nov 16, 2021
| @@ -229,7 +229,7 @@ private void exportSchema(PrintWriter out) { | |||
| } | |||
|
|
|||
| private List<String> exportIndexes() { | |||
| return db.executeTransactionally("CALL db.indexes()", Collections.emptyMap(), result -> result.stream() | |||
| return db.executeTransactionally("SHOW INDEXES", Collections.emptyMap(), result -> result.stream() | |||
There was a problem hiding this comment.
can we presume that the result columns have not changed between these two calls?
There was a problem hiding this comment.
Nope, there is one change: "provider" is replaced by "indexProvider"
There was a problem hiding this comment.
But from what I could see in this method we never care about that field so I think we are good.
burqen
force-pushed
the
5.0-ap-show-indexes
branch
from
e5707b9
to
d1caf51
Compare
|
Amended some updates. Ping @Lojjs |
|
I will merge this and monitor https://live.neo4j-build.io/buildConfiguration/Apoc_Dev_BuildAndCreateArtifacts?mode=builds#all-projects |
|
... well... shit... I can't merge either... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.