Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to not use deprecated index and constraint syntax #2385

Conversation

Hunterness
Copy link

They are currently in progress of being removed and are therefore in need of being updated

Copy link

@HannesSandberg HannesSandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have problem with building this branch, maybe you could help me out.

Found some more places to update:

CREATE CONSTRAINT ON ... ASSERT in SchemasTest.java

db.index.fulltext in SignatureTest.java and signatures.csv

@@ -231,7 +231,8 @@ private void exportSchema(PrintWriter out) {
private List<String> exportIndexes() {
return db.executeTransactionally("CALL db.indexes()", Collections.emptyMap(), result -> result.stream()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change CALL db.index() here as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this method is the one causing https://trello.com/c/KJUMznPU/2751-apoc-failures-due-to-removal-of-dbindexes and can not yet be removed without breaking things

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I see

@Hunterness
Copy link
Author

db.index.fulltext in SignatureTest.java and signatures.csv

is it the create or query methods? cause it is only create/drop that are being removed, the query ones are still valid

@HannesSandberg
Copy link

db.index.fulltext in SignatureTest.java and signatures.csv

is it the create or query methods? cause it is only create/drop that are being removed, the query ones are still valid

Ok, these are not create so should be fine then

@conker84
Copy link
Collaborator

Hi @Hunterness what is the status of this one?

@Hunterness
Copy link
Author

@conker84 Not really sure, I don't know why it doesn't build but I would like to see a green build before merging to know I have fixed things properly (I had issues with building things locally in general so I can't even check it myself)

@Hunterness Hunterness force-pushed the 5.0-update-to-new-index-constraint-syntax branch from 2192047 to 01b1dc5 Compare February 11, 2022 10:31
Copy link

@HannesSandberg HannesSandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I get a few test failures when building this locally. But as far as I can tell it has nothing to do with these changes.

@Hunterness
Copy link
Author

Hunterness commented Feb 14, 2022

@conker84 I managed got get it to build locally, and all tests I have changed seems to work now so it should be ready to be merged (and hope nothing else breaks)

@Hunterness Hunterness merged commit 3ac9ef4 into neo4j-contrib:dev Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants