Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2325: added property filters #2593

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Mar 1, 2022

Fixes #2325

Added nodePropFilter and relPropFilter,
with key the label / rel-type consistently with nodePropertyMappings and relPropertyMappings.

The values are the property keys to be filtered.

Resolve the linked issue together with the #2592

@Lojjs Lojjs added the 4.3 label Mar 28, 2022
@JMHReif
Copy link
Contributor

JMHReif commented Apr 11, 2022

@vga91, looks like we have conflicts with the previous Config boolean (isCleanup) with the additions in this PR. We want both, correct?

<<<<<<< issue_2325_filter_props
        this.nodePropFilter = (Map<String, List<String>>) config.getOrDefault("nodePropFilter", Collections.emptyMap());
        this.relPropFilter = (Map<String, List<String>>) config.getOrDefault("relPropFilter", Collections.emptyMap());
=======
        this.cleanup = Util.toBoolean(config.get("cleanup"));
>>>>>>> 4.3

@vga91
Copy link
Collaborator Author

vga91 commented Apr 12, 2022

@vga91, looks like we have conflicts with the previous Config boolean (isCleanup) with the additions in this PR. We want both, correct?

<<<<<<< issue_2325_filter_props
        this.nodePropFilter = (Map<String, List<String>>) config.getOrDefault("nodePropFilter", Collections.emptyMap());
        this.relPropFilter = (Map<String, List<String>>) config.getOrDefault("relPropFilter", Collections.emptyMap());
=======
        this.cleanup = Util.toBoolean(config.get("cleanup"));
>>>>>>> 4.3

Exactly. I just rebased it with both of them.

@JMHReif JMHReif merged commit 6752ba4 into neo4j-contrib:4.3 Apr 13, 2022
vga91 added a commit to vga91/neo4j-apoc-procedures that referenced this pull request May 25, 2022
vga91 added a commit that referenced this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symmetric export-import for JSON documents
3 participants