Fixes #1152 and #2247: Deleting nodes when having an apoc.trigger registered returns Neo.DatabaseError.Transaction.TransactionCommitFailed #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
changed the title
vga91
force-pushed
the
issue-1152
branch
4 times, most recently
from
49f6d85
to
80a8774
Compare
…having an apoc.trigger registered returns Neo.DatabaseError.Transaction.TransactionCommitFailed
JMHReif
approved these changes
May 3, 2022
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
May 17, 2022
…abaseError.Transaction.TransactionCommitFailed (neo4j-contrib#2596) Fixes neo4j-contrib#1152 and neo4j-contrib#2247
conker84
added a commit
that referenced
this pull request
May 17, 2022
…abaseError.Transaction.TransactionCommitFailed (#2596) (#2899) Fixes #1152 and #2247 Co-authored-by: Giuseppe Villani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2247
Changed TriggerMetadata.rebindDeleted(), not to leverage on
node.getLabels(),node.getAllProperties(),rel.getAllProperties()(these fail),but respectively on
txData.removedLabels(),txData.removedNodeProperties()andtxData.removedRelationshipProperties().rebindDeletedinTriggerMetadata.from(..)to removedRelationshipProperties, removedNodeProperties and removedLabels to leverage on virtual entities.TriggerTest.javaFixes #1152
apoc.trigger.toNodeandapoc.trigger.toRelationshipto retrieve labels and props entity infos with phase 'before' and 'after' (viaapoc.any.propertiesandapoc.node.labelsfunctions), similarly toTriggerMetadata.rebindDeleted()function (which is called only with phase 'afterAsync')TriggerExtendedTest.java